-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow linear to be consumed by nvFuser by default #1371
base: main
Are you sure you want to change the base?
Allow linear to be consumed by nvFuser by default #1371
Conversation
There are multiple concerning CI failures:
|
Co-authored-by: Jingyue Wu <[email protected]>
We did not run Thunder benchmarks using nvfuser linear. Should we run other benchmarks as well before enabling it by default? Additionally, @wujingyue needed to remove support for 1D weights to facilitate DID-aware execution. We might have to add an additional check on Thunder side or use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
orthogonal to this PR but related to nvfuser knobs: are there enable_foobar
s other than linear and matmul?
Yes, there's also |
CI with torch-nightly is now passing with NVIDIA/Fuser#3369 fixed. CI with older versions of torch (and therefore older versions of nvFuser) still fail, because we can't fix a past version. @IvanYashchuk, can you up nvFuser's version and enable linear only for that? |
Yes, I will do that. |
I'm unsure about the lightning-thunder (ipynb) test. Is that an infra failure or indeed a regression? |
For some reason, there was a timeout in the cell execution. Let's try rerunning the failed job. |
@kiya00, could you please check what's going on with the Notebooks CI job? |
This change lowers peak memory usage of LitGPT implementations that use
mlp_class_name="GptNeoxMLP"
configuration (#1175, #1233, #246).Better memory usage comes from simplifying the setup for Thunder's fusion rematerialization. With this change, there are fewer "producer" fusions.
cc @Priya2698, @wujingyue